Is the "what" required to come after "all"? Are the following sentences grammatically correct? What is the grammar point here? I understood that there should be a subject and a main verb. In this case, should the subject be "all what I've done"? Or "all I've done"?

1) All (what) I've done is sleep. 2) After all (what) I've done, I still fail to ...

  • 2
    "After all what I've done..." would be perceived as illiterate by the average American English speaker. You do hear it, but usually only from actors playing "country bumpkins" on TV. – Hot Licks May 21 '15 at 12:31

No, "what" should never appear in these constructions. But you could use "that".

1) All that I've done is sleep.

2) After all that I've done, I still fail to ...

However, it's also fine without.

| improve this answer | |
  • Thanks. Is there a reason? I kept on googling it and interestingly, I found this: meta.stackexchange.com/questions/245820/… Apparently, "what" is used, so is it grammatically incorrect then? But somehow I remember hearing it quite often, and that's why I got confused and started questioning my own usage. – Sally May 21 '15 at 8:30
  • 1
    @Sally: the example you give was written by someone who also wrote I thinked it well and an user. I would not assume anything is correct just because someone wrote it on the internet, especially if there are indications that that person is not a native speaker who is paying attention to writing carefully. – oerkelens May 21 '15 at 8:36

Your examples don't look proper. Here are my suggestions:

  • All I have done is sleep.

  • What I have done is sleep.

| improve this answer | |
  • Thanks. What if it follows "after". I believe it's either "all" or "what" in the 1st sentence and both of the suggestions provided by you. But somehow it sounds awkward if it's "After all I've done, I still failed the competition." – Sally May 21 '15 at 8:02
  • @Sally I would say: After all that I HAD done, I still failed the competition. I think someone else might give you a better explanation of ‘what’’s usage. – LWTBP May 21 '15 at 9:01

Not the answer you're looking for? Browse other questions tagged or ask your own question.