This question already has an answer here:

Sorry I am not a native English speaker but in an English language country.

My colleague was singing and just to kid her I said:

Whom you are singing for

(I wanted to say to her, for who she is singing this song) but I'm not sure if my use was correct or not.

marked as duplicate by tchrist, Andrew Leach, MetaEd, TrevorD, Matt E. Эллен Jul 29 '13 at 12:15

This question has been asked before and already has an answer. If those answers do not fully address your question, please ask a new question.

  • 1
    "Whom are you singing for?" would more clearly ask a question, whereas your wording is declarative instead of inquisitive. "For whom are you singing?" would be equally correct, with a slightly different emphasis. – Pieter Geerkens Jul 29 '13 at 4:54
  • 2
    Read the answers to this question: What's the rule for using "who" and "whom" correctly? – Mari-Lou A Jul 29 '13 at 5:13
  • Whom are you singing for? is neither good colloquial English nor good formal written English. Nobody uses whom unless they are impersonating someone important, and nobody doing that would ever strand a preposition. – John Lawler Jul 29 '13 at 16:58