Some things about "Shanghai" most people will nowadays agree on.
- Its use is not common, there are plenty of better synonyms that won't raise a single eye-brow.
- Using a word that means something negative, connected with a country or ethnicity, would be especially undesirable in today's society.