Take the 2-minute tour ×
English Language & Usage Stack Exchange is a question and answer site for linguists, etymologists, and serious English language enthusiasts. It's 100% free, no registration required.

Which one of these sentences is correct?

  1. That is one of my favourite songs of all time.
  2. That is one of my favourite songs of all times.

I am not a native English speaker.

share|improve this question
    
From Google Books - "favorite song of all time":499 hits, "favorite song of all times":10 hits. That's a pretty strong preference. –  FumbleFingers Jul 29 '12 at 22:23
    
My all time favourite song is it correct ?? –  user43661 May 3 '13 at 15:36

3 Answers 3

up vote 5 down vote accepted

I would say "of all time" because it means "from every time".

Saying "of all times" is certainly not incorrect, however, it just sounds awkward.

Check out Google's ngram viewer to see which is more popular:enter image description here

And it appears "of all time" is more popular.

share|improve this answer

"Of all time" is correct because it means "of all of time" as in the whole of time throughout existence (or throughout one's existence). Time is singular.

The only other problem in the sentence, "That is one of my favourite songs of all time," would only be a problem in the United States. In the U.S., the word is spelled "favorite."

share|improve this answer
    
Thanks for the note on "favourite" vs "favorite". –  zendar May 28 '11 at 23:48
1  
No problem. :) Many other words fit this same pattern. In In the UK: colour, flavour, etc. In the US: color, flavor, etc. –  Eri May 28 '11 at 23:55
2  
I think "uncountable" rather than "singular". –  Ben Voigt May 29 '11 at 0:08

It's a good question about which is more grammatically correct, but the first is a common (cliched) way of phrasing it, so it is more likely to sound correct to a native English speaker, at least in the US. The second version just doesn't sound right.

share|improve this answer

Your Answer

 
discard

By posting your answer, you agree to the privacy policy and terms of service.

Not the answer you're looking for? Browse other questions tagged or ask your own question.